lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <8bd0f97a1001231113r4a88120x83377572b78c1f48@mail.gmail.com>
Date:	Sat, 23 Jan 2010 14:13:35 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	David Miller <davem@...emloft.net>
Cc:	vapier@...too.org, linux-kernel@...r.kernel.org,
	rostedt@...dmis.org, fweisbec@...il.com, mingo@...hat.com,
	heiko.carstens@...ibm.com, lethal@...ux-sh.org
Subject: Re: [PATCH v2] ftrace: unify arch_syscall_addr() implementations

On Sat, Jan 23, 2010 at 03:28, David Miller <davem@...emloft.net> wrote:
> From: Mike Frysinger <vapier@...too.org>
> Date: Sat, 23 Jan 2010 02:10:43 -0500
>
>> Most implementations of arch_syscall_addr() are the same, so create a
>> default weak version in common code.  New arch ports don't have to waste
>> time copying & pasting this simple function.  The Blackfin version is
>> going to be exactly the same for example.
>>
>> The s390/sparc versions need to be different, so document why.
>>
>> Signed-off-by: Mike Frysinger <vapier@...too.org>
>
> You can just have the extern declaration match whatever the
> arch needs (long or int) in the generic ftrace.c code and
> then unconditionally do the (unsigned long) case.
>
> That way even s390/sparc can use the generic implementation.

asm/syscall.h is the most reasonable location to move the decls to in
asm/ ... people OK with that ?
-mike
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ