linux-kernel - Re: [PATCH 10/12] ACPI: processor: refactor internal map_lsapic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1001251421440.27862@chino.kir.corp.google.com>
Date:	Mon, 25 Jan 2010 14:22:17 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Alex Chiang <achiang@...com>
cc:	lenb@...nel.org, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 10/12] ACPI: processor: refactor internal
 map_lsapic_id()

On Mon, 25 Jan 2010, Alex Chiang wrote:

> diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
> index 9213f95..ec5989c 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -83,27 +83,17 @@ static int map_lsapic_id(struct acpi_subtable_header *entry,
>  {
>  	struct acpi_madt_local_sapic *lsapic =
>  		(struct acpi_madt_local_sapic *)entry;
> -	u32 tmp = (lsapic->id << 8) | lsapic->eid;
>  
> -	/* Only check enabled APICs*/
>  	if (!(lsapic->lapic_flags & ACPI_MADT_ENABLED))
>  		return 0;
>  
> -	/* Device statement declaration type */
>  	if (device_declaration) {
> -		if (entry->length < 16)
> -			printk(KERN_ERR PREFIX
> -			    "Invalid LSAPIC with Device type processor (SAPIC ID %#x)\n",
> -			    tmp);

Why drop this error message?

> -		else if (lsapic->uid == acpi_id)
> -			goto found;
> -	/* Processor statement declaration type */
> -	} else if (lsapic->processor_id == acpi_id)
> -		goto found;
> +		if ((entry->length < 16) || (lsapic->uid != acpi_id))
> +			return 0;
> +	} else if (lsapic->processor_id != acpi_id)
> +		return 0;
>  
> -	return 0;
> -found:
> -	*apic_id = tmp;
> +	*apic_id = (lsapic->id << 8) | lsapic->eid;
>  	return 1;
>  }
>  
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/