linux-kernel - Re: [RFC PATCH 1/2] Fix 1 untangling ima mess, part 2 with counters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100126162730.GI19799@ZenIV.linux.org.uk>
Date:	Tue, 26 Jan 2010 16:27:30 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Cc:	linux-kernel@...r.kernel.org, Eric Paris <eparis@...hat.com>,
	Hugh Dickins <hugh.dickins@...cali.co.uk>,
	James Morris <jmorris@...ei.org>,
	David Safford <safford@...son.ibm.com>,
	"Serge E. Hallyn" <serue@...ux.vnet.ibm.com>,
	Mimi Zohar <zohar@...ibm.com>
Subject: Re: [RFC PATCH 1/2] Fix 1 untangling ima mess, part 2 with counters

On Tue, Jan 26, 2010 at 10:16:55AM -0500, Mimi Zohar wrote:
> --- security-testing-2.6.orig/init/main.c
> +++ security-testing-2.6/init/main.c
> @@ -663,9 +663,9 @@ asmlinkage void __init start_kernel(void
>  	proc_caches_init();
>  	buffer_init();
>  	key_init();
> +	radix_tree_init();
>  	security_init();
>  	vfs_caches_init(totalram_pages);
> -	radix_tree_init();
>  	signals_init();
>  	/* rootfs populating might need page-writeback */
>  	page_writeback_init();

FWIW, I'd take radix_tree_init() much earlier than that; it's a common
infrastructure and if we have it early it'll mean less headache.

AFAICS, it can go right after mm_init().  Objections, anyone?

Other than that, I'm OK with that one.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/