linux-kernel - Re: [PATCH] scripts/kallsyms build warning fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2375c9f91001251902p3d632fbdr4c34e43c0973e68f@mail.gmail.com>
Date:	Tue, 26 Jan 2010 11:02:34 +0800
From:	Américo Wang <xiyou.wangcong@...il.com>
To:	Himanshu Chauhan <hschauhan@...ltrace.org>
Cc:	Linux Kernel <linux-kernel@...r.kernel.org>, greg@...ah.com
Subject: Re: [PATCH] scripts/kallsyms build warning fix

On Tue, Jan 26, 2010 at 5:41 AM, Himanshu Chauhan
<hschauhan@...ltrace.org> wrote:
> Hi all,
>
> This is a small patch that fixes the build warning
> of scripts/kallsyms.c
>
> Regards
> Himanshu
>
> Signed-off-by: Himanshu Chauhan <hschauhan@...ltrace.org>
> ---
>  scripts/kallsyms.c |    6 ++++--
>  1 files changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/scripts/kallsyms.c b/scripts/kallsyms.c
> index 86c3896..e3902fb 100644
> --- a/scripts/kallsyms.c
> +++ b/scripts/kallsyms.c
> @@ -108,8 +108,10 @@ static int read_symbol(FILE *in, struct sym_entry *s)
>        rc = fscanf(in, "%llx %c %499s\n", &s->addr, &stype, str);
>        if (rc != 3) {
>                if (rc != EOF) {
> -                       /* skip line */
> -                       fgets(str, 500, in);
> +                       /* skip line. sym is used as dummy to
> +                        * shut of "warn_unused_result" warning.
> +                        */
> +                       sym = fgets(str, 500, in);
>                }
>                return -1;
>        }

Why not use the return value to do some useful checking?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/