linux-kernel - Re: [PATCH] Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b0ae6fcc1001270049m6e2e7b1dre9971e57e282b48a@mail.gmail.com>
Date:	Wed, 27 Jan 2010 10:49:11 +0200
From:	Shahar Havivi <shaharh@...il.com>
To:	Jiri Kosina <jkosina@...e.cz>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Remove unused variables

Remove unused fields in drivers/char/vt.c
variables orig_buf and orig_count are assigned but never used.

Signed-off-by: Shahar Havivi <shaharh@...il.com>
---
 drivers/char/vt.c |    4 ----
 1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/char/vt.c b/drivers/char/vt.c
index 50faa1f..94f530a 100644
--- a/drivers/char/vt.c
+++ b/drivers/char/vt.c
@@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
const unsigned char *buf, int co
    uint8_t inverse;
    uint8_t width;
    u16 himask, charmask;
-   const unsigned char *orig_buf = NULL;
-   int orig_count;

    if (in_interrupt())
        return count;
@@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
const unsigned char *buf, int co
        release_console_sem();
        return 0;
    }
-   orig_buf = buf;
-   orig_count = count;

    himask = vc->vc_hi_font_mask;
    charmask = himask ? 0x1ff : 0xff;
-- 
1.6.3.3

On Wed, Jan 27, 2010 at 12:43 AM, Jiri Kosina <jkosina@...e.cz> wrote:
> On Wed, 20 Jan 2010, Shahar Havivi wrote:
>
>> Remove unused fields in drivers/char/vt.c
>> variables orig_buf and orig_count are assigned but never used.
>> Shahar Havivi
>
> Could you please resend with your Signed-off-by line, as described in
> Documentation/SubmittingPatches, so that I could apply the patch?
>
>> ---
>>  drivers/char/vt.c |    4 ----
>>  1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/char/vt.c b/drivers/char/vt.c
>> index 50faa1f..94f530a 100644
>> --- a/drivers/char/vt.c
>> +++ b/drivers/char/vt.c
>> @@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
>> const unsigned char *buf, int co
>>     uint8_t inverse;
>>     uint8_t width;
>>     u16 himask, charmask;
>> -   const unsigned char *orig_buf = NULL;
>> -   int orig_count;
>>
>>     if (in_interrupt())
>>         return count;
>> @@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
>> const unsigned char *buf, int co
>>         release_console_sem();
>>         return 0;
>>     }
>> -   orig_buf = buf;
>> -   orig_count = count;
>>
>>     himask = vc->vc_hi_font_mask;
>>     charmask = himask ? 0x1ff : 0xff;
>
> Thanks,
>
> --
> Jiri Kosina
> SUSE Labs, Novell Inc.
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/