linux-kernel - Re: [PATCH] Remove unused variables

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1001271013580.30977@pobox.suse.cz>
Date:	Wed, 27 Jan 2010 10:15:20 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Shahar Havivi <shaharh@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Remove unused variables

On Wed, 27 Jan 2010, Shahar Havivi wrote:

> Remove unused fields in drivers/char/vt.c
> variables orig_buf and orig_count are assigned but never used.
> 
> Signed-off-by: Shahar Havivi <shaharh@...il.com>
> ---
>  drivers/char/vt.c |    4 ----
>  1 files changed, 0 insertions(+), 4 deletions(-)
> diff --git a/drivers/char/vt.c b/drivers/char/vt.c
> index 50faa1f..94f530a 100644
> --- a/drivers/char/vt.c
> +++ b/drivers/char/vt.c
> @@ -2119,8 +2119,6 @@ static int do_con_write(struct tty_struct *tty,
> const unsigned char *buf, int co
>     uint8_t inverse;
>     uint8_t width;
>     u16 himask, charmask;
> -   const unsigned char *orig_buf = NULL;
> -   int orig_count;
> 
>     if (in_interrupt())
>         return count;
> @@ -2142,8 +2140,6 @@ static int do_con_write(struct tty_struct *tty,
> const unsigned char *buf, int co
>         release_console_sem();
>         return 0;
>     }
> -   orig_buf = buf;
> -   orig_count = count;
> 
>     himask = vc->vc_hi_font_mask;
>     charmask = himask ? 0x1ff : 0xff;

Your patch is whitespace damaged and line wrapped.

I have fixed it by hand and applied it, but please fix your mail client 
for any patch submissions in the future.

Thanks,

-- 
Jiri Kosina
SUSE Labs, Novell Inc.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/