linux-kernel - Re: [PATCH 3/3] [RFC] nmi_watchdog: config option to enable new nmi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100128154448.GV4472@redhat.com>
Date:	Thu, 28 Jan 2010 10:44:48 -0500
From:	Don Zickus <dzickus@...hat.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	mingo@...e.hu, gorcunov@...il.com, aris@...hat.com,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] [RFC] nmi_watchdog: config option to enable new
 nmi_watchdog

On Thu, Jan 28, 2010 at 03:54:54PM +0100, Peter Zijlstra wrote:
> On Wed, 2010-01-27 at 15:03 -0500, Don Zickus wrote:
> > These are the bits that enable the new nmi_watchdog and safely isolate the
> > old nmi_watchdog.  Only one or the other can run, not both at the same
> > time.
> 
> perf disables the lapic watchdog when it wants the pmu, so there
> shouldn't be a problem having both built in.

Yes it does disable but does not prevent nmi_watchdog_tick from running
nor the /proc interface from being loaded.  So perhaps my description
isn't very good.  The idea with the new watchdog was to re-use some of the
bits of the old one, but having them both compiled in seemed to stomp on
each other.  That is what I was trying to prevent.

I can certainly change the behaviour, just makes the code a little more
messy I think.

Cheers,
Don
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/