linux-kernel - Re: [PATCH 25/68] it8213: always program control bits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B631C88.2020307@ru.mvista.com>
Date:	Fri, 29 Jan 2010 20:36:08 +0300
From:	Sergei Shtylyov <sshtylyov@...mvista.com>
To:	Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
Cc:	linux-ide@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 25/68] it8213: always program control bits

Hello.

Bartlomiej Zolnierkiewicz wrote:

> From: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> Subject: [PATCH] it8213: always program control bits
>
> This matches behavior of libata pata_it8213 host driver.
>
> Signed-off-by: Bartlomiej Zolnierkiewicz <bzolnier@...il.com>
> ---
>  drivers/ide/it8213.c |    6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
>
> Index: b/drivers/ide/it8213.c
> ===================================================================
> --- a/drivers/ide/it8213.c
> +++ b/drivers/ide/it8213.c
> @@ -55,15 +55,13 @@ static void it8213_set_pio_mode(ide_hwif
>  	if (is_slave) {
>  		master_data |=  0x4000;
>  		master_data &= ~0x0070;
> -		if (pio > 1)
> -			master_data = master_data | (control << 4);
> +		master_data = master_data | (control << 4);
>   

    master_data |= control << 4; /* it's C after all */

>  		pci_read_config_byte(dev, slave_port, &slave_data);
>  		slave_data = slave_data & 0xf0;
>  		slave_data = slave_data | (timings[pio][0] << 2) | timings[pio][1];
>  	} else {
>  		master_data &= ~0x3307;
> -		if (pio > 1)
> -			master_data = master_data | control;
> +		master_data = master_data | control;
>   

    master_data |= control;

>  		master_data = master_data | (timings[pio][0] << 12) | (timings[pio][1] << 8);
>   

MBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/