linux-kernel - arch/arm/mach-omap2/mux.c: Off by one error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <BLU108-W14539E61D58BF455B82CA59C590@phx.gbl>
Date:	Sun, 31 Jan 2010 12:16:52 +0000
From:	d binderman <dcb314@...mail.com>
To:	<tony@...mide.com>
CC:	<linux-kernel@...r.kernel.org>
Subject: arch/arm/mach-omap2/mux.c: Off by one error



Hello there,

I just ran the sourceforge tool cppcheck over the source code of the
new Linux kernel 2.6.33-rc6

It said

[./arm/mach-omap2/mux.c:492]: (error) Buffer access out-of-bounds

The source code is

        char mode[14];
        int i = -1;

        sprintf(mode, "OMAP_MUX_MODE%d", val & 0x7);

13 characters + 1 digit + 1 zero byte is more than 14 characters.

Suggest new code

        char mode[15];
        int i = -1;

        sprintf(mode, "OMAP_MUX_MODE%d", val & 0x7);


Regards

David Binderman


 		 	   		  
_________________________________________________________________
Tell us your greatest, weirdest and funniest Hotmail stories
http://clk.atdmt.com/UKM/go/195013117/direct/01/--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/