[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20100201044124.GA29097@localhost>
Date: Mon, 1 Feb 2010 12:41:24 +0800
From: Wu Fengguang <fengguang.wu@...el.com>
To: akpm@...ux-foundation.org, linux-mm@...ck.org,
linux-kernel@...r.kernel.org, y-goto@...fujitsu.com,
haveblue@...ibm.com, kamezawa.hiroyu@...fujitsu.com,
ak@...ux.intel.com, hpa@...nel.org, haicheng.li@...el.com,
shaohui.zheng@...ux.intel.com
Subject: Re: [Patch - Resend v4] Memory-Hotplug: Fix the bug on interface
/dev/mem for 64-bit kernel
Shaohui,
Some style nitpicks..
> #ifdef CONFIG_MEMORY_HOTPLUG
> +/**
Should use /* here.
> + * After memory hotplug, the variable max_pfn, max_low_pfn and high_memory will
> + * be affected, it will be updated in this function.
> + */
> +static inline void __meminit update_end_of_memory_vars(u64 start,
The "inline" and "__meminit" are both redundant here.
> + max_low_pfn = max_pfn = end_pfn;
One assignment per line is preferred.
Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists