linux-kernel - Re: [PATCH 2/2] scsi: add scsi trace core function and put trace points

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4B665BE7.8040001@jp.fujitsu.com>
Date:	Mon, 01 Feb 2010 13:43:19 +0900
From:	Kei Tokunaga <tokunaga.keiich@...fujitsu.com>
To:	"Martin K. Petersen" <martin.petersen@...cle.com>
CC:	linux-scsi@...r.kernel.org,
	James Bottomley <James.Bottomley@...e.de>,
	Ingo Molnar <mingo@...hat.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	lkml <linux-kernel@...r.kernel.org>,
	Li Zefan <lizf@...fujitsu.com>,
	Xiao Guangrong <xiaoguangrong@...fujitsu.com>,
	Tomohiro Kusumi <kusumi.tomohiro@...fujitsu.com>,
	Kei Tokunaga <tokunaga.keiich@...fujitsu.com>
Subject: Re: [PATCH 2/2] scsi: add scsi trace core function and put trace
 points

Martin K. Petersen wrote:
>>>>>> "Kei" == Kei Tokunaga <tokunaga.keiich@...fujitsu.com> writes:
> 
> +	TP_printk("host_no=%u channel=%u id=%u lun=%u cmnd=(%s %s raw=%s) "
>                               ^^^^^^^^^^
> 
> I'm not sure anybody cares about channels in this millennium so that may
> be a waste of space.
> 
> 
> +scsi_trace_rw10(struct trace_seq *p, unsigned char *cdb, int len)
> +scsi_trace_rw12(struct trace_seq *p, unsigned char *cdb, int len)
> +scsi_trace_rw16(struct trace_seq *p, unsigned char *cdb, int len)
> +scsi_trace_rw32(struct trace_seq *p, unsigned char *cdb, int len)
> 
> Would be handy to get FUA and {RD,WR}PROTECT decoded in these commands.
> And prot_op would be nice too.
> 
> Other decode-worthy commands might be WRITE SAME(16) and UNMAP.

Thanks for the suggestions.  I'm going to post v2 series of this
patchset soon, and please note, in that version, I didn't add the
decoding on these stuff you mentioned above.

> +scsi_trace_parse_cdb(struct trace_seq *p, unsigned char *cdb, int len)
> +{
>         [...]
> +	case READ_32:
> +	case WRITE_32:
> +		return scsi_trace_rw32(p, cdb, len);
> 
> This won't work.  READ/WRITE(32) are variable length commands.  They
> share the same operation code and are distinguished by the service
> action field.  Several of the most recent additions to the SCSI
> protocols are implemented like this.
> 
> Other commands requiring two-level parsing are READ CAPACITY(16) and GET
> LBA STATUS.

This is definitely a valid point.  In the v2 patchset, I tried to
fix it.  (Only DIF_TYPE2 READ/WRITE(32) are handled in that
version.)  It'd be great if you would review it.

I'm sorry that I didn't reply sooner.

Thanks,
Kei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/