linux-kernel - Re: [lm-sensors] [PATCH 04/10] drivers/hwmon/vt8231.c: Fix continuation line formats

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 2 Feb 2010 08:56:51 +0100
From:	Jean Delvare <khali@...ux-fr.org>
To:	Joe Perches <joe@...ches.com>
Cc:	linux-kernel@...r.kernel.org,
	Roger Lucas <vt8231@...denengine.co.uk>,
	lm-sensors@...sensors.org
Subject: Re: [lm-sensors] [PATCH 04/10] drivers/hwmon/vt8231.c: Fix
 continuation  line formats

Hi Joe,

On Mon,  1 Feb 2010 23:22:10 -0800, Joe Perches wrote:
> String constants that are continued on subsequent lines with \
> are not good.
> 
> Signed-off-by: Joe Perches <joe@...ches.com>
> ---
>  drivers/hwmon/vt8231.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c
> index d47b4c9..e6078c9 100644
> --- a/drivers/hwmon/vt8231.c
> +++ b/drivers/hwmon/vt8231.c
> @@ -948,8 +948,7 @@ static int __devinit vt8231_pci_probe(struct pci_dev *dev,
>  
>  	address = val & ~(VT8231_EXTENT - 1);
>  	if (address == 0) {
> -		dev_err(&dev->dev, "base address not set -\
> -				 upgrade BIOS or use force_addr=0xaddr\n");
> +		dev_err(&dev->dev, "base address not set - upgrade BIOS or use force_addr=0xaddr\n");
>  		return -ENODEV;
>  	}
>  

Good catch, and thanks for the fix. But now we have an overlong line,
which checkpatch will complain about. So I would prefer if you'd fix
the problem by replacing the \ by a pair of ".

-- 
Jean Delvare
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/