[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date: Tue, 02 Feb 2010 00:01:07 -0800
From: Joe Perches <joe@...ches.com>
To: Jean Delvare <khali@...ux-fr.org>
Cc: linux-kernel@...r.kernel.org,
Roger Lucas <vt8231@...denengine.co.uk>,
lm-sensors@...sensors.org
Subject: Re: [lm-sensors] [PATCH 04/10] drivers/hwmon/vt8231.c: Fix
continuation line formats
On Tue, 2010-02-02 at 08:56 +0100, Jean Delvare wrote:
> > diff --git a/drivers/hwmon/vt8231.c b/drivers/hwmon/vt8231.c
> > index d47b4c9..e6078c9 100644
> > --- a/drivers/hwmon/vt8231.c
> > +++ b/drivers/hwmon/vt8231.c
> > @@ -948,8 +948,7 @@ static int __devinit vt8231_pci_probe(struct pci_dev *dev,
> >
> > address = val & ~(VT8231_EXTENT - 1);
> > if (address == 0) {
> > - dev_err(&dev->dev, "base address not set -\
> > - upgrade BIOS or use force_addr=0xaddr\n");
> > + dev_err(&dev->dev, "base address not set - upgrade BIOS or use force_addr=0xaddr\n");
> > return -ENODEV;
> > }
> >
>
> Good catch, and thanks for the fix. But now we have an overlong line,
> which checkpatch will complain about. So I would prefer if you'd fix
> the problem by replacing the \ by a pair of ".
That depends on what version of checkpatch you're using.
There's one with a pr_<level> and dev_<level> exemption
to the long line check.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists