linux-kernel - Re: Re: [RFC] Dell activity led WMI driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100203015341.GA21173@core.coreip.homeip.net>
Date:	Tue, 2 Feb 2010 17:53:42 -0800
From:	Dmitry Torokhov <dmitry.torokhov@...il.com>
To:	Bob Rodgers <Robert_Rodgers@...l.com>
Cc:	Linux-kernel <linux-kernel@...r.kernel.org>,
	Matthew Garrett <mjg59@...f.ucam.org>, lenb@...nel.org,
	rpurdie@...ys.net
Subject: Re: Re: [RFC] Dell activity led WMI driver

Hi Bob,

On Tue, Feb 02, 2010 at 03:27:11PM -0600, Bob Rodgers wrote:
> 
> static int __init dell_led_probe(struct platform_device *pdev)
> {

This should either be changed to __devinit or you need to call
platform_device_probe() or, even better, use platform_create_bundle()
that is in next.

But isn't it a bit wasteful to create a brand new platform device only
to attach a single led device to it? I think that, even thourgh LED GUID
is separate, it would be better to keep all this functionality in
dell-wmi driver.

Thanks.

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/