linux-kernel - Re: [PATCH 2/3] trace-cmd: fix printf compile warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <520f0cf11002030840j3b1ab71eu5a6a3c918458f845@mail.gmail.com>
Date:	Wed, 3 Feb 2010 17:40:17 +0100
From:	John Kacur <jkacur@...hat.com>
To:	rostedt@...dmis.org
Cc:	Darren Hart <dvhltc@...ibm.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] trace-cmd: fix printf compile warnings

On Wed, Feb 3, 2010 at 5:31 PM, Steven Rostedt <rostedt@...dmis.org> wrote:
> On Wed, 2010-02-03 at 17:07 +0100, John Kacur wrote:
>> On Mon, Feb 1, 2010 at 5:50 PM, Darren Hart <dvhltc@...ibm.com> wrote:
>> > Signed-off-by: Darren Hart <dvhltc@...ibm.com>
>> > ---
>> >  trace-read.c |    2 +-
>> >  1 files changed, 1 insertions(+), 1 deletions(-)
>> >
>> > diff --git a/trace-read.c b/trace-read.c
>> > index a04c85b..5befaba 100644
>> > --- a/trace-read.c
>> > +++ b/trace-read.c
>> > @@ -216,7 +216,7 @@ static void read_rest(void)
>> >                r = read(input_fd, buf, BUFSIZ);
>> >                if (r > 0) {
>> >                        buf[r] = 0;
>> > -                       printf(buf);
>> > +                       printf("%s", buf);
>> >                }
>> >        } while (r > 0);
>> >  }
>> > --
>> > 1.6.3.3
>> >
>>
>> Oh! Obviously correct, thanks Darren.
>
> Of the three patches, I think this is the only one that is correct ;-)
>

Ah, you're a hard taskmaster! Are you going to push it to your repo
for us then pls?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/