[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <fa686aa41002030835t7046ed3bk33deed2c2f631263@mail.gmail.com>
Date: Wed, 3 Feb 2010 09:35:12 -0700
From: Grant Likely <grant.likely@...retlab.ca>
To: Amit Kucheria <amit.kucheria@...onical.com>
Cc: List Linux Kernel <linux-kernel@...r.kernel.org>,
linux-arm-kernel@...ts.infradead.org, linux@....linux.org.uk,
s.hauer@...gutronix.de, valentin.longchamp@...l.ch,
daniel@...aq.de, Dinh.Nguyen@...escale.com,
r.herring@...escale.com, bryan.wu@...onical.com
Subject: Re: [PATCHv2 04/11] mxc: changes to common plat-mxc code to add
support for i.MX5
On Tue, Feb 2, 2010 at 10:16 PM, Amit Kucheria
<amit.kucheria@...onical.com> wrote:
> Changes separted to help in the review process
<soapbox>Commit log needs to talk about what the patch is, not how it
has changed. Please state what the patch does and why. It is also
helpful to have testing information. The goal is to make it easy for
both patch reviewers on the mailing list *and* people looking at the
commit in git after it is merged. This commit message doesn't provide
the reader with any helpful information.
Patch version/review information like your comment above typically
goes below the '---' line.</soapbox>
g.
--
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists