linux-kernel - Re: [PATCH][mmotm-2010-02-01-16-25] Fix wrong accouting of anon and file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1002031007150.14088@chino.kir.corp.google.com>
Date:	Wed, 3 Feb 2010 10:20:29 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Minchan Kim <minchan.kim@...il.com>
cc:	Andrew Morton <akpm@...ux-foundation.org>,
	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>,
	Christoph Lameter <cl@...ux-foundation.org>,
	Lee Schermerhorn <lee.schermerhorn@...com>,
	linux-mm <linux-mm@...ck.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][mmotm-2010-02-01-16-25] Fix wrong accouting of anon and
 file

On Thu, 4 Feb 2010, Minchan Kim wrote:

> Unfortunately, Kame said he doesn't support this series.
> I am not sure we need this patch or revert patch.
> 

Nobody is currently using it and it adds an overhead just by doing the 
extra branches, so I'd be inclined to drop mm-count-lowmem-rss.patch from 
-mm and then reintroduce it later if something needs it down the line.

> Who need this?
> 
> David. Do you want to remain this patch in mmotm for your OOM patch 
> in future?
> 

We'll need to do something for lowmem ooms so that we aren't needlessly 
killing taks that don't consume it.  At this point, I think it's better to 
just fail GFP_DMA allocations where direct reclaim (and, later, memory 
compaction) has failed unless it is __GFP_NOFAIL, which none of them are.  
So this would be a change to the page allocator to defer the oom killer 
and return NULL on GFP_DMA instead of needlessly killing tasks.

> If anyone doesn't reply my question, Do we have to make revert patch?
> 

We won't need a revert patch, Andrew will be able to simply drop 
mm-count-lowmem-rss.patch from -mm.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/