lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 04 Feb 2010 16:49:12 -0500 From: Eric Paris <eparis@...hat.com> To: "Serge E. Hallyn" <serue@...ibm.com> Cc: James Morris <jmorris@...ei.org>, Kees Cook <kees.cook@...onical.com>, Alex Riesen <raa.lkml@...il.com>, Casey Schaufler <casey@...aufler-ca.com>, linux-security-module@...r.kernel.org, David Howells <dhowells@...hat.com>, Alexey Dobriyan <adobriyan@...il.com>, Ingo Molnar <mingo@...e.hu>, Andrew Morton <akpm@...ux-foundation.org>, Simon Kagstrom <simon.kagstrom@...insight.net>, David Woodhouse <David.Woodhouse@...el.com>, Robin Getz <rgetz@...log.com>, Greg Kroah-Hartman <gregkh@...e.de>, Paul Moore <paul.moore@...com>, Tetsuo Handa <penguin-kernel@...ove.sakura.ne.jp>, Stephen Smalley <sds@...ho.nsa.gov>, Etienne Basset <etienne.basset@...ericable.fr>, "David P. Quigley" <dpquigl@...ho.nsa.gov>, LKLM <linux-kernel@...r.kernel.org> Subject: Re: [PATCH v2 1/2] syslog: distinguish between /proc/kmsg and syscalls On Thu, 2010-02-04 at 15:31 -0600, Serge E. Hallyn wrote: > Quoting James Morris (jmorris@...ei.org): > > On Thu, 4 Feb 2010, Kees Cook wrote: > > > > > Hi Alex, > > > > > > On Thu, Feb 04, 2010 at 08:58:43AM +0100, Alex Riesen wrote: > > > > > + /* /proc/kmsg can open be opened by CAP_SYS_ADMIN */ > > > > > + if (type != 1 && from_file) > > > > > + return 0; > > > > > > > > "can open be opened"? > > > > > > Erk, sorry. s/open // > > > > > > James, do you want a patch for that? > > > > I guess... and 'opened with' might be better. > > I'd still as mentioned yesterday prefer "requires CAP_SYS_ADMIN to open" > Otherwise, every time I see the comment I expect stricter requirements, > not laxer ones, on the other actions. However, I think with the second > patch switching 1 for a meaningful name, the comment isn't even necessary > or noticable any more. Agreed, the names make the function understandable, the comment confused the mess out of me. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists