linux-kernel - Re: [PATCH -next] libertas/if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1265320377.4290.7.camel@localhost.localdomain>
Date:	Thu, 04 Feb 2010 13:52:57 -0800
From:	Dan Williams <dcbw@...hat.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Stephen Rothwell <sfr@...b.auug.org.au>,
	akpm <akpm@...ux-foundation.org>,
	Andrey Yurovsky <andrey@...ybit.com>,
	Colin McCabe <colin@...ybit.com>, linux-next@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	linux-wireless@...r.kernel.org
Subject: Re: [PATCH -next] libertas/if_spi: needs linux/semaphore.h

On Wed, 2010-02-03 at 15:31 -0800, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> libertas/if_spi.c needs to #include linux/semaphore.h to fix build errors:
> 
> drivers/net/wireless/libertas/if_spi.c:59: error: field 'spi_ready' has incomplete type
> drivers/net/wireless/libertas/if_spi.c:60: error: field 'spi_thread_terminated' has incomplete type
> drivers/net/wireless/libertas/if_spi.c:785: error: implicit declaration of function 'down_interruptible'
> drivers/net/wireless/libertas/if_spi.c:787: error: implicit declaration of function 'up'
> drivers/net/wireless/libertas/if_spi.c:834: error: implicit declaration of function 'down'
> drivers/net/wireless/libertas/if_spi.c:943: error: implicit declaration of function 'sema_init'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>

Acked-by: Dan Williams <dcbw@...hat.com>

> ---
>  drivers/net/wireless/libertas/if_spi.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- linux-next-20100203.orig/drivers/net/wireless/libertas/if_spi.c
> +++ linux-next-20100203/drivers/net/wireless/libertas/if_spi.c
> @@ -23,6 +23,7 @@
>  #include <linux/kthread.h>
>  #include <linux/list.h>
>  #include <linux/netdevice.h>
> +#include <linux/semaphore.h>
>  #include <linux/spi/libertas_spi.h>
>  #include <linux/spi/spi.h>
>  


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/