linux-kernel - Re: [PATCH 10/17] MTD: nand: make reads using MTD_OOB

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1265361901.15383.9.camel@maxim-laptop>
Date:	Fri, 05 Feb 2010 11:25:01 +0200
From:	Maxim Levitsky <maximlevitsky@...il.com>
To:	Vitaly Wool <vitalywool@...il.com>
Cc:	David Woodhouse <dwmw2@...radead.org>,
	Alex Dubov <oakad@...oo.com>,
	Artem Bityutskiy <dedekind1@...il.com>,
	joern <joern@...fs.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	linux-mtd <linux-mtd@...ts.infradead.org>,
	Thomas Gleixner <tglx@...utronix.de>
Subject: Re: [PATCH 10/17] MTD: nand: make reads using MTD_OOB_RAW affect
 only  ECC validation

On Fri, 2010-02-05 at 09:56 +0100, Vitaly Wool wrote: 
> On Fri, Feb 5, 2010 at 12:30 AM, Maxim Levitsky <maximlevitsky@...il.com> wrote:
> > This changes the behavier of MTD_OOB_RAW. It used to read both OOB and data
> > to the data buffer, however you would still need to specify the dummy oob buffer.
> >
> > This is only used in one place, but makes it hard to read data+oob without ECC
> > test, thus I removed that behavier, and fixed the user.
> >
> > Now MTD_OOB_RAW behaves like MTD_OOB_PLACE, but doesn't do ECC validation
> >
> > Signed-off-by: Maxim Levitsky <maximlevitsky@...il.com>
> > ---
> >  drivers/mtd/nand/nand_base.c |    5 -----
> >  drivers/mtd/nand/nand_bbt.c  |   26 ++++++++++++++++++++++----
> >  include/linux/mtd/mtd.h      |    4 +---
> >  3 files changed, 23 insertions(+), 12 deletions(-)
> 
> Could you please provide a clearer description of why you think this
> is necessary?

Sure.

I have two distinct buffers. One holds the data and is 512 bytes long,
other is the oob and is 16 bytes long.

I want to write these buffers to flash but without ECC

Currently I would have to allocate new buffer and copy both buffers
there.

Why I need it?

To make my SmartMedia FTL complete I need to add support for 256 byte
nands. These have 256 bytes per page and 8 bytes of oob.
However, pages are always written in pairs, forming 512 bytes sector.
Combined oob of first and second page is identical to the one that is
written to 512 byte page, thus its layout depends on page number.
Also I want the nand driver to have as little as possible smartmedia
dependencies, thus allow it to be used with any FTL, UBI, jffs2, etc..
Therefore I decided to make nand driver use standard oob layout and ECC
in case of 256 byte flash, but make my FTL bypass it.
It also happens to work with nandsim unmodified... :-)

Also, this makes the interface more orthogonal.
This feature is used in just one place too.

Best regards,
Maxim Levitsky

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/