linux-kernel - Re: [PATCH 03/11] tracing: Inject lock_class

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1265379199.24386.26.camel@gandalf.stny.rr.com>
Date:	Fri, 05 Feb 2010 09:13:19 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Frederic Weisbecker <fweisbec@...il.com>
Cc:	Ingo Molnar <mingo@...e.hu>, LKML <linux-kernel@...r.kernel.org>,
	Peter Zijlstra <peterz@...radead.org>,
	Arnaldo Carvalho de Melo <acme@...hat.com>,
	Paul Mackerras <paulus@...ba.org>,
	Hitoshi Mitake <mitake@....info.waseda.ac.jp>,
	Li Zefan <lizf@...fujitsu.com>,
	Lai Jiangshan <laijs@...fujitsu.com>,
	Masami Hiramatsu <mhiramat@...hat.com>,
	Jens Axboe <jens.axboe@...cle.com>,
	Johannes Berg <johannes@...solutions.net>
Subject: Re: [PATCH 03/11] tracing: Inject lock_class_init events on
 registration

On Wed, 2010-02-03 at 10:14 +0100, Frederic Weisbecker wrote:

>  static inline void lockdep_off(void)
> diff --git a/include/trace/events/lock.h b/include/trace/events/lock.h
> index 90af03c..6999f16 100644
> --- a/include/trace/events/lock.h
> +++ b/include/trace/events/lock.h
> @@ -9,7 +9,7 @@
>  
>  #ifdef CONFIG_LOCKDEP
>  
> -TRACE_EVENT(lock_class_init,
> +TRACE_EVENT_INJECT(lock_class_init,
>  
>  	TP_PROTO(struct lock_class *class),
>  
> @@ -30,7 +30,14 @@ TRACE_EVENT(lock_class_init,
>  		__entry->class_id = (void *)class->name;
>  	),
>  
> -	TP_printk("%p %s", __entry->class_id, __get_str(class_name))
> +	TP_printk("%p %s", __entry->class_id, __get_str(class_name)),
> +
> +	/*
> +	 * On activation, we want to send an event for each lock
> +	 * classes that have been recorded by lockdep, so that we
> +	 * catch up with the existing class:name mappings.
> +	 */
> +	lock_class_init_inject_events
>  );
>  

I also suggested this type of registering:

register_event_callback("event", "command", command_func, 
		command_enable_func,
		command_disable_func);

Where command_func, command_enable_func and command_disable_func can all
be a function pointer or NULL.

command_func gets called every time the event is hit while enabled.

command_enable_func gets called when the event is enabled

command_disable_func gets called when the event is disabled.

Hmm,

I could make it so that if the string "command" is NULL that these
functions are registered permanent, and can not be disabled by the user?
Otherwise, the user needs to set them with "echo command > command"

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/