linux-kernel - Re: [PATCH] inotify/fsnotify: tree-watching support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 5 Feb 2010 11:30:20 -0500
From:	Eric Paris <eparis@...isplace.org>
To:	Joris Dolderer <vorstadtkind@...glemail.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] inotify/fsnotify: tree-watching support

On Fri, Feb 5, 2010 at 8:51 AM, Joris Dolderer
<vorstadtkind@...glemail.com> wrote:
> Hi,
>
> This is my first software submit, so please don't spare with detailed
> constructive critics and be nice to me ;-).

I would suggest that you take a careful look at
Documentation/CodingStyle and Documentation/SubmittingPatches.  There
appear to be quite a number of issues which you may believe to be
purely cosmetic or aesthetic but coding style and proper submission of
 patches are very important to keeping the kernel easy to maintain and
develop further.

I will try to take a look a the contents of the patch over the weekend
and will give you some feedback.

Thanks!
-Eric
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/