linux-kernel - RE: [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <14385191E87B904DBD836449AA30269D5CC333@MORGANITE.micrel.com>
Date:	Thu, 4 Feb 2010 18:55:31 -0800
From:	"Ha, Tristram" <Tristram.Ha@...rel.Com>
To:	"Stephen Hemminger" <shemminger@...tta.com>
Cc:	"Dave Miller" <davem@...emloft.net>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices

Stephen Hemminger wrote:
> On Thu, 4 Feb 2010 15:28:29 -0800
> "Ha, Tristram" <Tristram.Ha@...rel.Com> wrote:
> 
>> From: Tristram Ha <Tristram.Ha@...rel.com>
>> 
>> Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices.
>> 
>> Signed-off-by: Tristram Ha <Tristram.Ha@...rel.com> ---
>> This is a resubmission of the Micrel KSZ8841/2 PCI Ethernet driver.
>> 
>> --- linux-2.6.33-rc5.old/include/linux/pci_ids.h	2010-01-21
15:31:35.000000000 -0800
>> +++ linux-2.6.33-rc5.new/include/linux/pci_ids.h	2010-01-29
10:38:53.000000000 -0800 @@ -2199,6
>>  +2199,12 @@ #define PCI_VENDOR_ID_NETCELL		0x169c
>>  #define PCI_DEVICE_ID_REVOLUTION	0x0044
>> 
>> +#define PCI_VENDOR_ID_MICREL_KS		0x16c6
>> +#define PCI_DEVICE_ID_MICREL_KS8692	0x8692
>> +#define PCI_DEVICE_ID_MICREL_KS8695	0x8695
>> +#define PCI_DEVICE_ID_MICREL_KS8841	0x8841
>> +#define PCI_DEVICE_ID_MICREL_KS8842	0x8842
>> +
>>  #define PCI_VENDOR_ID_CENATEK		0x16CA
>>  #define PCI_DEVICE_ID_CENATEK_IDE	0x0001
>> 
> 
> Current practice is to NOT update this file and instead keep constants
in the individual driver.

It seems I received conflicted recommendation from Alan Cox:

>> >> +#define PCI_VENDOR_ID_KS884X		0x16C6
>> >> +#define PCI_DEVICE_ID_KS8841		0x8841
>> >> +#define PCI_DEVICE_ID_KS8842		0x8842
>> > 
>> > Those belong in the pci device id header.
>> > 
>> > 
>> 
>> I do not quite understand your suggestion.  Do I need to put those
IDs 
>> in one of the kernel headers?
> 
> Into include/linux/pci_ids.h

So I do not need to update pci_ids.h with even the PCI vendor ID?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/