linux-kernel - Re: [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for Micrel KSZ8841/2 PCI devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100204.202754.252960217.davem@davemloft.net>
Date:	Thu, 04 Feb 2010 20:27:54 -0800 (PST)
From:	David Miller <davem@...emloft.net>
To:	Tristram.Ha@...rel.Com
Cc:	shemminger@...tta.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.33 4/4] net: Add PCI vendor and device ids for
 Micrel KSZ8841/2 PCI devices

From: "Ha, Tristram" <Tristram.Ha@...rel.Com>
Date: Thu, 4 Feb 2010 18:55:31 -0800

> Stephen Hemminger wrote:
>> Current practice is to NOT update this file and instead keep constants
> in the individual driver.
> 
> It seems I received conflicted recommendation from Alan Cox:

Alan's understanding is several years out of date.

Stephen's is correct.

But you don't need these stupid defines at all, all you
use them for is the PCI device ID table in your driver
so just use constants.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/