linux-kernel - Re: [GIT][IMA] fix null pointer deref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100207075658.GF30031@ZenIV.linux.org.uk>
Date:	Sun, 7 Feb 2010 07:56:58 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	James Morris <jmorris@...ei.org>
Cc:	Linus Torvalds <torvalds@...ux-foundation.org>,
	Xiaotian Feng <dfeng@...hat.com>,
	Eric Paris <eparis@...hat.com>, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, serue@...ux.vnet.ibm.com,
	Eugene Teo <eugene@...hat.com>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Subject: Re: [GIT][IMA] fix null pointer deref

On Sun, Feb 07, 2010 at 06:34:51PM +1100, James Morris wrote:
> Linus,
> 
> Please pull this bugfix.  I've verified that it fixes the null pointer 
> deref.

NAK.  In that form it's simply wrong; we should never get there with
NULL file->f_dentry->d_inode at all.  This is papering over the real
bug; I'll post a saner fix shortly.

The real problem is BS hiding of ima_file_free() inside a hook, with
condition that kinda-sorta happens to avoid bogus call most of the
time.

ima_path_check() side is also of BUG_ON() variety (and isn't triggered).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/