linux-kernel - Re: [GIT][IMA] fix null pointer deref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <OF4ED37009.B78CBF20-ON852576C4.0012975E-852576C4.00145EA3@us.ibm.com>
Date:	Sun, 7 Feb 2010 22:42:29 -0500
From:	Mimi Zohar <zohar@...ibm.com>
To:	Al Viro <viro@...IV.linux.org.uk>
Cc:	Xiaotian Feng <dfeng@...hat.com>, Eric Paris <eparis@...hat.com>,
	Eugene Teo <eugene@...hat.com>,
	James Morris <jmorris@...ei.org>, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org,
	linux-security-module-owner@...r.kernel.org,
	serue@...ux.vnet.ibm.com,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>
Subject: Re: [GIT][IMA] fix null pointer deref

Al Viro wrote on 02/07/2010 02:56:58 AM:

> On Sun, Feb 07, 2010 at 06:34:51PM +1100, James Morris wrote:
> > Linus,
> > 
> > Please pull this bugfix.  I've verified that it fixes the null pointer 

> > deref.
> 
> NAK.  In that form it's simply wrong; we should never get there with
> NULL file->f_dentry->d_inode at all.  This is papering over the real
> bug; I'll post a saner fix shortly.
> 
> The real problem is BS hiding of ima_file_free() inside a hook, with
> condition that kinda-sorta happens to avoid bogus call most of the
> time.
> 
> ima_path_check() side is also of BUG_ON() variety (and isn't triggered).

hm, there was quite a bit of discussion that IMA should be called from
the security hooks (refer to http://lkml.org/lkml/2009/6/7/279),  so
commit 6c21a7f "LSM: imbed ima calls in the security hooks" moved them.

Mimi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/