linux-kernel - Re: [Patch] cpufreq: fix a deadlock during shutting down

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1002090117160.9056@chino.kir.corp.google.com>
Date:	Tue, 9 Feb 2010 01:22:11 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Amerigo Wang <amwang@...hat.com>
cc:	linux-kernel@...r.kernel.org, Xiaotian Feng <xtfeng@...il.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>,
	Dave Jones <davej@...hat.com>, cpufreq@...r.kernel.org,
	Prarit Bhargava <prarit@...hat.com>,
	Thomas Renninger <trenn@...e.de>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
Subject: Re: [Patch] cpufreq: fix a deadlock during shutting down

On Tue, 9 Feb 2010, Amerigo Wang wrote:

> Benjamin reported that, the machine deadlocks right after printing the
> following when doing a shutdown:
> 
> halt/4071 is trying to acquire lock:
>  (s_active){++++.+}, at: [<c0000000001ef868>] .sysfs_addrm_finish+0x58/0xc0
> 
> but task is already holding lock:
>  (&per_cpu(cpu_policy_rwsem, cpu)){+.+.+.}, at: [<c0000000004cd6ac>] .lock_policy_rwsem_write+0x84/0xf4
> 
> which lock already depends on the new lock.
> 
> the existing dependency chain (in reverse order) is:
> 
> <nothing else ... machine deadlocked here>
> 
> 
> This is because we are trying to kobject_put() a kobject while
> we are holding cpu policy rwsem. So just move kobject_put()
> down after releasing the rwsem.
> 
> Totally untested.
> 
> Reported-by: Xiaotian Feng <xtfeng@...il.com>
> Reported-by: Benjamin Herrenschmidt <benh@...nel.crashing.org>
> Signed-off-by: WANG Cong <amwang@...hat.com>
> Cc: Dave Jones <davej@...hat.com>
> Cc: Thomas Renninger <trenn@...e.de>
> Cc: Prarit Bhargava <prarit@...hat.com>
> Cc: Venkatesh Pallipadi <venkatesh.pallipadi@...el.com>
> 
> ---
> diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
> index 67bc2ec..222b35f 100644
> --- a/drivers/cpufreq/cpufreq.c
> +++ b/drivers/cpufreq/cpufreq.c
> @@ -1113,6 +1113,7 @@ static int __cpufreq_remove_dev(struct sys_device *sys_dev)
>  	unsigned int cpu = sys_dev->id;
>  	unsigned long flags;
>  	struct cpufreq_policy *data;
> +	struct kobject *kobj;
>  #ifdef CONFIG_SMP
>  	struct sys_device *cpu_sys_dev;
>  	unsigned int j;
> @@ -1192,7 +1193,7 @@ static int __cpufreq_remove_dev(struct sys_device *sys_dev)
>  	if (cpufreq_driver->target)
>  		__cpufreq_governor(data, CPUFREQ_GOV_STOP);
>  
> -	kobject_put(&data->kobj);
> +	kobj = &data->kobj;
>  
>  	/* we need to make sure that the underlying kobj is actually
>  	 * not referenced anymore by anybody before we proceed with

NACK.

If you read this comment, it says:

	/* we need to make sure that the underlying kobj is actually
	 * not referenced anymore by anybody before we proceed with
	 * unloading.
	 */

That would suggest that the wait_for_completion(&data->kobj_unregister); 
would never actually return if you're holding a reference to it in your 
patch since it only completes when the last reference is dropped (the 
->release function is cpufreq_sysfs_release()).
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/