linux-kernel - Re: [PATCH 28/35] radix: move radix init early

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <84144f021002091156q5cbf6adcj3c1d86b00a6e5285@mail.gmail.com>
Date:	Tue, 9 Feb 2010 21:56:41 +0200
From:	Pekka Enberg <penberg@...helsinki.fi>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Yinghai Lu <yinghai@...nel.org>, Ingo Molnar <mingo@...e.hu>,
	Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 28/35] radix: move radix init early

On Tue, Feb 9, 2010 at 9:49 PM, Andrew Morton <akpm@...ux-foundation.org> wrote:
> On Tue, 09 Feb 2010 11:32:39 -0800
> Yinghai Lu <yinghai@...nel.org> wrote:
>
>> prepare to use it in early_irq_init()
>>
>> Signed-off-by: Yinghai Lu <yinghai@...nel.org>
>> ---
>>  init/main.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/init/main.c b/init/main.c
>> index 4cb47a1..8451878 100644
>> --- a/init/main.c
>> +++ b/init/main.c
>> @@ -584,6 +584,7 @@ asmlinkage void __init start_kernel(void)
>>               local_irq_disable();
>>       }
>>       rcu_init();
>> +     radix_tree_init();
>>       /* init some links before init_ISA_irqs() */
>>       early_irq_init();
>>       init_IRQ();
>> @@ -657,7 +658,6 @@ asmlinkage void __init start_kernel(void)
>>       proc_caches_init();
>>       buffer_init();
>>       key_init();
>> -     radix_tree_init();
>>       security_init();
>>       vfs_caches_init(totalram_pages);
>>       signals_init();
>
> Probably OK.  Note that radix_tree_init() uses slab, and it is now being
> called before the kernel has run kmem_cache_init_late().  So please
> ensure that this code was tested with CONFIG_SLAB=y.

That should be fine but yeah, definitely needs to be tested.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/