linux-kernel - Re: [PATCH 04/35] x86/pci: amd one chain system to use pci read out res

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20100209115411.95cee659.akpm@linux-foundation.org>
Date:	Tue, 9 Feb 2010 11:54:11 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Yinghai Lu <yinghai@...nel.org>
Cc:	Ingo Molnar <mingo@...e.hu>, Thomas Gleixner <tglx@...utronix.de>,
	"H. Peter Anvin" <hpa@...or.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Christoph Lameter <cl@...ux-foundation.org>,
	linux-kernel@...r.kernel.org, linux-pci@...r.kernel.org
Subject: Re: [PATCH 04/35] x86/pci: amd one chain system to use pci read out
 res

On Tue, 09 Feb 2010 11:32:15 -0800
Yinghai Lu <yinghai@...nel.org> wrote:

> --- a/arch/x86/pci/amd_bus.c
> +++ b/arch/x86/pci/amd_bus.c
> @@ -87,11 +87,12 @@ static int __init early_fill_mp_bus_info(void)
>  	struct range range[RANGE_NUM];
>  	u64 val;
>  	u32 address;
> +	int found;

It'd be clearer to give this the `bool' type.  After all, it's a bool.

>  
>  	if (!early_pci_allowed())
>  		return -1;
>  
> -	found_all_numa_early = 0;
> +	found = 0;
>  	for (i = 0; i < ARRAY_SIZE(pci_probes); i++) {
>  		u32 id;
>  		u16 device;
> @@ -105,12 +106,12 @@ static int __init early_fill_mp_bus_info(void)
>  		device = (id>>16) & 0xffff;
>  		if (pci_probes[i].vendor == vendor &&
>  		    pci_probes[i].device == device) {
> -			found_all_numa_early = 1;
> +			found = 1;
>  			break;
>  		}
>  	}
>  
> -	if (!found_all_numa_early)
> +	if (!found)
>  		return 0;
>  
>  	pci_root_num = 0;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/