linux-kernel - Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100210110011.GN30031@ZenIV.linux.org.uk>
Date:	Wed, 10 Feb 2010 11:00:11 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in
 pohmelfs

On Wed, Feb 10, 2010 at 01:45:15PM +0300, Evgeniy Polyakov wrote:

> > To mountpoint or to fs root?  And what's going on with d_find_alias()?
> 
> To root if it happend to be under mountpoint.

HUH?  How the hell can root of filesystem be under the mountpoint of
that filesystem?  What are you talking about?

> > AFAICS, you are doing that for regular files as well as directories,
> > and you do support link(2) in there, so dentry (and path) obtained from
> > that will be random.
> 
> Not exactly random, but can change.
> Links support is rather subtle because of that, yes.
> 
> Plan was to add external attribute or increase inode size to include
> parent name, but when I coded that it was so messy in respect of
> renames, that was dropped.

Why not use the dentries you've been given by VFS?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/