linux-kernel - Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in pohmelfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100210115938.GO30031@ZenIV.linux.org.uk>
Date:	Wed, 10 Feb 2010 11:59:39 +0000
From:	Al Viro <viro@...IV.linux.org.uk>
To:	Evgeniy Polyakov <zbr@...emap.net>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [WTF] ... is going on with current->fs->{root,mnt} accesses in
 pohmelfs

On Wed, Feb 10, 2010 at 02:11:15PM +0300, Evgeniy Polyakov wrote:
> On Wed, Feb 10, 2010 at 11:00:11AM +0000, Al Viro (viro@...IV.linux.org.uk) wrote:
> > > > To mountpoint or to fs root?  And what's going on with d_find_alias()?
> > > 
> > > To root if it happend to be under mountpoint.
> > 
> > HUH?  How the hell can root of filesystem be under the mountpoint of
> > that filesystem?  What are you talking about?
> 
> Let me guess... Mmmm, it was in the yesterday newspaper, I remember.
> Maybe when we chroot somewhere. I meant not mounted fs root, but
> thread's root.

Why would a filesystem give a damn about the chroot of syscall originator
in the first place?

> > Why not use the dentries you've been given by VFS?
> 
> At writeback we do not have parents, so must find a path somehow.

Most of the places do have those just fine and unlike the writeback,
rename et.al. really care which pathname is being dealt with...

BTW, what prevents writeback vs. rename races?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/