[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <1265846123-2244-1-git-send-email-kirill@shutemov.name>
Date: Thu, 11 Feb 2010 01:55:23 +0200
From: "Kirill A. Shutemov" <kirill@...temov.name>
To: linux-mm@...ck.org
Cc: linux-kernel@...r.kernel.org,
"Kirill A. Shutemov" <kirill@...temov.name>,
Balbir Singh <balbir@...ux.vnet.ibm.com>,
Pavel Emelyanov <xemul@...nvz.org>,
KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
Subject: [PATCH mmotm] memcg: check if first threshold crossed
There is a bug in memory thresholds code. We don't check if first
threshold (array index 0) was crossed down. This patch fixes it.
Signed-off-by: Kirill A. Shutemov <kirill@...temov.name>
Cc: Balbir Singh <balbir@...ux.vnet.ibm.com>
Cc: Pavel Emelyanov <xemul@...nvz.org>
Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
---
mm/memcontrol.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/mm/memcontrol.c b/mm/memcontrol.c
index 41e00c2..a443c30 100644
--- a/mm/memcontrol.c
+++ b/mm/memcontrol.c
@@ -3252,7 +3252,7 @@ static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap)
* If none of thresholds below usage is crossed, we read
* only one element of the array here.
*/
- for (; i > 0 && unlikely(t->entries[i].threshold > usage); i--)
+ for (; i >= 0 && unlikely(t->entries[i].threshold > usage); i--)
eventfd_signal(t->entries[i].eventfd, 1);
/* i = current_threshold + 1 */
--
1.6.5.8
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists