linux-kernel - Re: [PATCH mmotm] memcg: check if first threshold crossed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20100212091429.d1115b17.kamezawa.hiroyu@jp.fujitsu.com>
Date:	Fri, 12 Feb 2010 09:14:29 +0900
From:	KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
To:	"Kirill A. Shutemov" <kirill@...temov.name>
Cc:	linux-mm@...ck.org, linux-kernel@...r.kernel.org,
	Balbir Singh <balbir@...ux.vnet.ibm.com>,
	Pavel Emelyanov <xemul@...nvz.org>
Subject: Re: [PATCH mmotm] memcg: check if first threshold crossed

On Thu, 11 Feb 2010 01:55:23 +0200
"Kirill A. Shutemov" <kirill@...temov.name> wrote:

> There is a bug in memory thresholds code. We don't check if first
> threshold (array index 0) was crossed down. This patch fixes it.
> 
> Signed-off-by: Kirill A. Shutemov <kirill@...temov.name>
> Cc: Balbir Singh <balbir@...ux.vnet.ibm.com>
> Cc: Pavel Emelyanov <xemul@...nvz.org>
> Cc: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

Acked-by: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>

> ---
>  mm/memcontrol.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> index 41e00c2..a443c30 100644
> --- a/mm/memcontrol.c
> +++ b/mm/memcontrol.c
> @@ -3252,7 +3252,7 @@ static void __mem_cgroup_threshold(struct mem_cgroup *memcg, bool swap)
>  	 * If none of thresholds below usage is crossed, we read
>  	 * only one element of the array here.
>  	 */
> -	for (; i > 0 && unlikely(t->entries[i].threshold > usage); i--)
> +	for (; i >= 0 && unlikely(t->entries[i].threshold > usage); i--)
>  		eventfd_signal(t->entries[i].eventfd, 1);
>  
>  	/* i = current_threshold + 1 */
> -- 
> 1.6.5.8
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/