linux-kernel - Re: [PATCH 1/1] Staging: hv: Add proper versioning to HV drivers-Corrected.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100211233612.GB10315@suse.de>
Date:	Thu, 11 Feb 2010 15:36:12 -0800
From:	Greg KH <gregkh@...e.de>
To:	Hank Janssen <hjanssen@...rosoft.com>
Cc:	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: Re: [PATCH 1/1] Staging: hv: Add proper versioning to HV
 drivers-Corrected.

Minor nits below:

On Thu, Feb 11, 2010 at 11:02:42PM +0000, Hank Janssen wrote:
> 
> Provide proper versioning information for all HV drivers.
> With removal of build time/date/and Minor number as requested
> By Greg KH
> 
> Cc: Greg Kroah-Hartman         <gregkh@...e.de>
> Signed-off-by: Hank Janssen    <hjanssen@...rosoft.com>
> Signed-off-by: Haiyang Zhang   <haiyang@...rosoft.com>

Don't line up the <email@...ain>, just put only one space, there are a
few hundred thousand examples to look at for the correct formatting :)

> 
>  drivers/staging/hv/VersionInfo.h |   22 +++++++++++++++++++---

You forgot a "---" between the signed-off-by and the diffstat.  If you
use either git or quilt, it will get this correct automagically.  That
infers you used something else, which is quite scary.  What are you
using instead to create patches?

Don't worry, I can edit this by hand when I apply it, and will do so in
a few days when I get to my "to-apply" queue, but in the future, please
don't do this.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/