linux-kernel - RE: [PATCH 1/1] Staging: hv: Add proper versioning to HV drivers-Corrected.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8AFC7968D54FB448A30D8F38F259C56212E88B0F@TK5EX14MBXC118.redmond.corp.microsoft.com>
Date:	Fri, 12 Feb 2010 17:55:34 +0000
From:	Hank Janssen <hjanssen@...rosoft.com>
To:	Greg KH <gregkh@...e.de>
CC:	"'linux-kernel@...r.kernel.org'" <linux-kernel@...r.kernel.org>,
	"devel@...verdev.osuosl.org" <devel@...verdev.osuosl.org>,
	Haiyang Zhang <haiyangz@...rosoft.com>
Subject: RE: [PATCH 1/1] Staging: hv: Add proper versioning to HV
 drivers-Corrected.


> >
> >  drivers/staging/hv/VersionInfo.h |   22 +++++++++++++++++++---
> 
> You forgot a "---" between the signed-off-by and the diffstat.  If you
> use either git or quilt, it will get this correct automagically.  That
> infers you used something else, which is quite scary.  What are you
> using instead to create patches?
> 
> Don't worry, I can edit this by hand when I apply it, and will do so in
> a few days when I get to my "to-apply" queue, but in the future, please
> don't do this.
> 
> thanks,
> 
> greg k-h

This must have been the result of a cut/paste error on my side.

I use the following command for my diff   'git diff -M -u --stat'

Btw, it was my understanding that the -M flag allows tracking of renamed 
files as well as part of the diff output. (git mv) But my diff command 
does not report on those.  Am I doing something wrong?

Thanks,

Hank.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/