linux-kernel - Re: [PATCH] [3/4] SLAB: Set up the l3 lists for the memory of freshly added memory v2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100216140447.GN5723@laptop>
Date:	Wed, 17 Feb 2010 01:04:47 +1100
From:	Nick Piggin <npiggin@...e.de>
To:	David Rientjes <rientjes@...gle.com>
Cc:	Andi Kleen <andi@...stfloor.org>,
	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org, linux-mm@...ck.org,
	haicheng.li@...el.com
Subject: Re: [PATCH] [3/4] SLAB: Set up the l3 lists for the memory of
 freshly added memory v2

On Mon, Feb 15, 2010 at 01:47:29PM -0800, David Rientjes wrote:
> On Mon, 15 Feb 2010, Nick Piggin wrote:
> 
> > > > @@ -1577,6 +1595,8 @@ void __init kmem_cache_init_late(void)
> > > >  	 */
> > > >  	register_cpu_notifier(&cpucache_notifier);
> > > >  
> > > > +	hotplug_memory_notifier(slab_memory_callback, SLAB_CALLBACK_PRI);
> > > > +
> > > 
> > > Only needed for CONFIG_NUMA, but there's no side-effects for UMA kernels 
> > > since status_change_nid will always be -1.
> > 
> > Compiler doesn't know that, though.
> > 
> 
> Right, setting up a memory hotplug callback for UMA kernels here isn't 
> necessary although slab_node_prepare() would have to be defined 
> unconditionally.  I made this suggestion in my review of the patchset's 
> initial version but it was left unchanged, so I'd rather see it included 
> than otherwise stall out.  This could always be enclosed in
> #ifdef CONFIG_NUMA later just like the callback in slub does.

It's not such a big burden to annotate critical core code with such
things. Otherwise someone else ends up eventually doing it.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/