linux-kernel - [PATCH] timer: print function name for timer callbacks modifying preemption count

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <1266335005-22780-1-git-send-email-u.kleine-koenig@pengutronix.de>
Date:	Tue, 16 Feb 2010 16:43:25 +0100
From:	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>
To:	linux-kernel@...r.kernel.org
Cc:	Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...e.hu>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Paul Mackerras <paulus@...ba.org>,
	Arun R Bharadwaj <arun@...ux.vnet.ibm.com>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: [PATCH] timer: print function name for timer callbacks modifying preemption count

A function scheduled with a timer must not exit with a different preempt
count than it was entered.
To make helping users running into the corresponding BUG() easier also
print the name of the bad function not only its address.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de>
---
 kernel/timer.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/kernel/timer.c b/kernel/timer.c
index c61a794..ef9a4db 100644
--- a/kernel/timer.c
+++ b/kernel/timer.c
@@ -1027,10 +1027,10 @@ static inline void __run_timers(struct tvec_base *base)
 				lock_map_release(&lockdep_map);
 
 				if (preempt_count != preempt_count()) {
-					printk(KERN_ERR "huh, entered %p "
+					printk(KERN_ERR "huh, entered %p (%pF)"
 					       "with preempt_count %08x, exited"
 					       " with %08x?\n",
-					       fn, preempt_count,
+					       fn, fn, preempt_count,
 					       preempt_count());
 					BUG();
 				}
-- 
1.6.6.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/