linux-kernel - Re: [PATCH 05/06] kernel.h tracing stuff cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1266849367.24271.4386.camel@gandalf.stny.rr.com>
Date:	Mon, 22 Feb 2010 09:36:06 -0500
From:	Steven Rostedt <rostedt@...dmis.org>
To:	Dave Young <hidave.darkstar@...il.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Neil Horman <nhorman@...driver.com>,
	Vivek Goyal <vgoyal@...hat.com>,
	Randy Dunlap <randy.dunlap@...cle.com>,
	Tom Zanussi <tzanussi@...il.com>,
	Vegard Nossum <vegard.nossum@...il.com>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Andi Kleen <ak@...ux.intel.com>,
	Simon Kagstrom <simon.kagstrom@...insight.net>,
	David Woodhouse <David.Woodhouse@...el.com>,
	Markus Metzger <markus.t.metzger@...el.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/06] kernel.h tracing stuff cleanup

On Mon, 2010-02-22 at 22:20 +0800, Dave Young wrote:
> trace stuff in kernel.h should stay in their own head file 
> 
> cleanup trace declarations in kernel.h, put them into ring_buffer.h
> include ring_buffer.h in every file which need it

NAK, sorry.

1) it does not belong in ring_buffer.h. The ring buffer.h is for the
ring buffer only, and is agnostic to other tracing code.

2) trace_prink() and friends needs to be with printk. It is not used
much in the delivered kernel but it is used often in development. That
is, we purposely made it so it is not needed to add a header file to
everyplace you use trace_prink(). When debugging a problem,
trace_printk() needs to be as convenient as adding printk(), and by
needing to find "what header includes trace_printk()" will become an
overwhelming inconvenience.

-- Steve


> 
> Signed-off-by: Dave Young <hidave.darkstar@...il.com>


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/