linux-kernel - Re: [PATCH] Staging: rtl8187se: fix spacing errors and commenting format in r8180

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100224004221.GA27872@kroah.com>
Date:	Tue, 23 Feb 2010 16:42:21 -0800
From:	Greg KH <greg@...ah.com>
To:	Richard Colquhoun <arfab@...abit.com>
Cc:	Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Staging: rtl8187se: fix spacing errors and commenting
 format in r8180_93cx6.c

> -	ret=0;
> -        //enable EPROM programming
> +	ret = 0;
> +	#enable EPROM programming

This is not valid C.  Please build the code before sending in patches.

Also, you might want to brush up on your C programming skills :)

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/