linux-kernel - Re: [PATCH] windfarm: init sysfs attributes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1266979753.23523.1670.camel@pasglop>
Date:	Wed, 24 Feb 2010 13:49:13 +1100
From:	Benjamin Herrenschmidt <benh@...nel.crashing.org>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Américo Wang <xiyou.wangcong@...il.com>,
	Kernel development list <linux-kernel@...r.kernel.org>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Greg KH <greg@...ah.com>
Subject: Re: [PATCH] windfarm: init sysfs attributes

On Sat, 2010-02-20 at 16:43 +0100, Johannes Berg wrote:
> This is required for lockdep.

Please CC linuxppc-dev@...abs.org or it doesn't get caught by patchwork.

I'll fwd that one myself.

Cheers,
Ben.

> Signed-off-by: Johannes Berg <johannes@...solutions.net>
> ---
>  drivers/macintosh/windfarm_core.c         |    1 +
>  drivers/macintosh/windfarm_smu_controls.c |    1 +
> 
> --- wireless-testing.orig/drivers/macintosh/windfarm_smu_controls.c	2010-02-20 16:05:55.738721565 +0100
> +++ wireless-testing/drivers/macintosh/windfarm_smu_controls.c	2010-02-20 16:07:51.996717974 +0100
> @@ -173,6 +173,7 @@ static struct smu_fan_control *smu_fan_c
>  
>  	fct->fan_type = pwm_fan;
>  	fct->ctrl.type = pwm_fan ? WF_CONTROL_PWM_FAN : WF_CONTROL_RPM_FAN;
> +	sysfs_attr_init(&fct->ctrl.attr.attr);
>  
>  	/* We use the name & location here the same way we do for SMU sensors,
>  	 * see the comment in windfarm_smu_sensors.c. The locations are a bit
> --- wireless-testing.orig/drivers/macintosh/windfarm_core.c	2010-02-20 16:15:14.701580166 +0100
> +++ wireless-testing/drivers/macintosh/windfarm_core.c	2010-02-20 16:15:38.416369684 +0100
> @@ -321,6 +321,7 @@ int wf_register_sensor(struct wf_sensor 
>  	kref_init(&new_sr->ref);
>  	list_add(&new_sr->link, &wf_sensors);
>  
> +	sysfs_attr_init(&new_sr->attr.attr);
>  	new_sr->attr.attr.name = new_sr->name;
>  	new_sr->attr.attr.mode = 0444;
>  	new_sr->attr.show = wf_show_sensor;
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/