linux-kernel - Re: [async_tx-next PATCH 1/2] fsldma: Fix cookie issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100225192159.GA32092@ovro.caltech.edu>
Date:	Thu, 25 Feb 2010 11:21:59 -0800
From:	"Ira W. Snyder" <iws@...o.caltech.edu>
To:	"Steven J. Magnani" <steve@...idescorp.com>
Cc:	Dan Williams <dan.j.williams@...el.com>,
	Zhang Wei <zw@...kernel.org>, linux-kernel@...r.kernel.org,
	linuxppc-dev@...abs.org
Subject: Re: [async_tx-next PATCH 1/2] fsldma: Fix cookie issues

On Mon, Feb 22, 2010 at 11:40:31AM -0600, Steven J. Magnani wrote:
> fsl_dma_tx_submit() only sets the cookie on the first descriptor of a
> transaction. It should set the cookie on all.
> 
> Signed-off-by: Steven J. Magnani <steve@...idescorp.com>
> ---
> diff -uprN a/drivers/dma/fsldma.c b/drivers/dma/fsldma.c
> --- a/drivers/dma/fsldma.c	2010-02-22 11:16:36.000000000 -0600
> +++ b/drivers/dma/fsldma.c	2010-02-22 11:24:01.000000000 -0600
> @@ -362,7 +362,7 @@ static dma_cookie_t fsl_dma_tx_submit(st
>  		if (cookie < 0)
>  			cookie = 1;
>  
> -		desc->async_tx.cookie = cookie;
> +		child->async_tx.cookie = cookie;
>  	}
>  
>  	chan->common.cookie = cookie;
> 

This looks correct to me. I'm not sure I ever tested the driver with a
chained struct dma_async_tx_descriptor.

Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/