linux-kernel - Re: [async_tx-next PATCH 2/2] fsldma: Fix cookie issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100225192539.GB32092@ovro.caltech.edu>
Date:	Thu, 25 Feb 2010 11:25:39 -0800
From:	"Ira W. Snyder" <iws@...o.caltech.edu>
To:	Guennadi Liakhovetski <g.liakhovetski@....de>
Cc:	"Steven J. Magnani" <steve@...idescorp.com>,
	Zhang Wei <zw@...kernel.org>,
	Dan Williams <dan.j.williams@...el.com>,
	linux-kernel@...r.kernel.org, linuxppc-dev@...abs.org
Subject: Re: [async_tx-next PATCH 2/2] fsldma: Fix cookie issues

On Mon, Feb 22, 2010 at 09:26:13PM +0100, Guennadi Liakhovetski wrote:
> On Mon, 22 Feb 2010, Steven J. Magnani wrote:
> 
> > diff -uprN a/include/linux/dmaengine.h b/include/linux/dmaengine.h
> > --- a/include/linux/dmaengine.h	2010-02-22 11:18:11.000000000 -0600
> > +++ b/include/linux/dmaengine.h	2010-02-22 11:18:30.000000000 -0600
> > @@ -31,6 +31,8 @@
> >   * if dma_cookie_t is >0 it's a DMA request cookie, <0 it's an error code
> >   */
> >  typedef s32 dma_cookie_t;
> > +#define DMA_MIN_COOKIE	1
> > +#define DMA_MAX_COOKIE	2147483647
> 
> Taking into account, that dma_cookie_t is 32 bits:
> 
> +#define DMA_MAX_COOKIE		((1 << 31) - 1)
> 

Steven,

After you take Guennadi's comment into acount, the rest of the patch
looks good. I'm sure I've never rolled the cookie around during testing.

Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/