linux-kernel - Re: [PATCH] Staging: dream: camera: msm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100226070415.GA14036@atrey.karlin.mff.cuni.cz>
Date:	Fri, 26 Feb 2010 08:04:15 +0100
From:	Pavel Machek <pavel@....cz>
To:	Chihau Chau <chihau@...il.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] Staging: dream: camera: msm_camera: fix code style
	issues

> From: Chihau Chau <chihau@...il.com>
> 
> This fixes some code style issues like to add one space after a while or
> switch statement and before a open parenthesis '(', and to include KERN_
> facility level in the printk() functions.
> 
> Signed-off-by: Chihau Chau <chihau@...il.com>

ACK.

> ---
>  drivers/staging/dream/camera/msm_camera.c |   17 ++++++++++-------
>  1 files changed, 10 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/staging/dream/camera/msm_camera.c b/drivers/staging/dream/camera/msm_camera.c
> index 925e16c..223918f 100644
> --- a/drivers/staging/dream/camera/msm_camera.c
> +++ b/drivers/staging/dream/camera/msm_camera.c
> @@ -76,14 +76,14 @@ static LIST_HEAD(msm_sensors);
>  		list_del_init(&qcmd->list);			\
>  		kfree(qcmd);					\
>  	};							\
> -} while(0)
> +} while (0)
>  
>  #define MSM_DRAIN_QUEUE(sync, name) do {			\
>  	unsigned long flags;					\
>  	spin_lock_irqsave(&(sync)->name##_lock, flags);		\
>  	MSM_DRAIN_QUEUE_NOSYNC(sync, name);			\
>  	spin_unlock_irqrestore(&(sync)->name##_lock, flags);	\
> -} while(0)
> +} while (0)
>  
>  static int check_overlap(struct hlist_head *ptype,
>  			unsigned long paddr,
> @@ -868,7 +868,7 @@ static int msm_config_vfe(struct msm_sync *sync, void __user *arg)
>  		return -EFAULT;
>  	}
>  
> -	switch(cfgcmd.cmd_type) {
> +	switch (cfgcmd.cmd_type) {
>  	case CMD_STATS_ENABLE:
>  		axi_data.bufnum1 =
>  			msm_pmem_region_lookup(&sync->stats,
> @@ -1621,7 +1621,8 @@ static int msm_release_control(struct inode *node, struct file *filep)
>  	int rc;
>  	struct msm_control_device *ctrl_pmsm = filep->private_data;
>  	struct msm_device *pmsm = ctrl_pmsm->pmsm;
> -	printk("msm_camera: RELEASE %s\n", filep->f_path.dentry->d_name.name);
> +	printk(KERN_INFO "msm_camera: RELEASE %s\n",
> +					filep->f_path.dentry->d_name.name);
>  	rc = __msm_release(pmsm->sync);
>  	if (!rc) {
>  		MSM_DRAIN_QUEUE(&ctrl_pmsm->ctrl_q, ctrl_status_q);
> @@ -1635,7 +1636,8 @@ static int msm_release_frame(struct inode *node, struct file *filep)
>  {
>  	int rc;
>  	struct msm_device *pmsm = filep->private_data;
> -	printk("msm_camera: RELEASE %s\n", filep->f_path.dentry->d_name.name);
> +	printk(KERN_INFO "msm_camera: RELEASE %s\n",
> +					filep->f_path.dentry->d_name.name);
>  	rc = __msm_release(pmsm->sync);
>  	if (!rc) {
>  		MSM_DRAIN_QUEUE(pmsm->sync, prev_frame_q);
> @@ -1719,7 +1721,7 @@ static void msm_vfe_sync(struct msm_vfe_resp *vdata,
>  	qcmd->type = qtype;
>  
>  	if (qtype == MSM_CAM_Q_VFE_MSG) {
> -		switch(vdata->type) {
> +		switch (vdata->type) {
>  		case VFE_MSG_OUTPUT1:
>  		case VFE_MSG_OUTPUT2:
>  			qcmd_frame =
> @@ -1928,7 +1930,8 @@ static int __msm_v4l2_control(struct msm_sync *sync,
>  	memcpy(out->value, ctrl->value, ctrl->length);
>  
>  end:
> -	if (rcmd) kfree(rcmd);
> +	if (rcmd)
> +		kfree(rcmd);
>  	CDBG("__msm_v4l2_control: end rc = %d\n", rc);
>  	return rc;
>  }

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/