linux-kernel - Re: [PATCH] Staging: dream: camera: sk5k3e2fx: fix code style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20100226070423.GB14036@atrey.karlin.mff.cuni.cz>
Date:	Fri, 26 Feb 2010 08:04:23 +0100
From:	Pavel Machek <pavel@....cz>
To:	Chihau Chau <chihau@...il.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] Staging: dream: camera: sk5k3e2fx: fix code style
	issues

> From: Chihau Chau <chihau@...il.com>
> 
> This fixes some code style issues about assignments in if conditions.
> 
> Signed-off-by: Chihau Chau <chihau@...il.com>

ACK.

> ---
>  drivers/staging/dream/camera/s5k3e2fx.c |    8 ++++----
>  1 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/dream/camera/s5k3e2fx.c b/drivers/staging/dream/camera/s5k3e2fx.c
> index edba198..2426f5e 100644
> --- a/drivers/staging/dream/camera/s5k3e2fx.c
> +++ b/drivers/staging/dream/camera/s5k3e2fx.c
> @@ -743,12 +743,12 @@ static int s5k3e2fx_sensor_open_init(const struct msm_camera_sensor_info *data)
>  	}
>  
>  	/* initialize AF */
> -	if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr,
> -			0x3146, 0x3A)) < 0)
> +	rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, 0x3146, 0x3A);
> +	if (rc < 0)
>  		goto init_fail1;
>  
> -	if ((rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr,
> -			0x3130, 0x03)) < 0)
> +	rc = s5k3e2fx_i2c_write_b(s5k3e2fx_client->addr, 0x3130, 0x03);
> +	if (rc < 0)
>  		goto init_fail1;
>  
>  	goto init_done;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/