linux-kernel - Re: [PATCH 1/2] serial: Add driver for the Altera JTAG UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100226112715.207bbd13@lxorguk.ukuu.org.uk>
Date:	Fri, 26 Feb 2010 11:27:15 +0000
From:	Alan Cox <alan@...rguk.ukuu.org.uk>
To:	Tobias Klauser <tklauser@...tanz.ch>
Cc:	linux-serial@...r.kernel.org, nios2-dev@...c.et.ntust.edu.tw,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] serial: Add driver for the Altera JTAG UART

> > Use tty_termios_copy_hw() to copy the old termios hardware settings back
> > so that the caller sees it cannot set them.
> 
> Would the following be sufficient?
> 
>   if (old)
>           tty_termios_copy_hw(termios, old);

That will do the trick yes.

>   spin_lock(&port->lock);
> 
>   if (isr & ALTERA_JTAGUART_CONTROL_RE_MSK)
>           altera_jtaguart_rx_chars(pp);
>   if (isr & ALTERA_JTAGUART_CONTROL_WE_MSK)
>           altera_jtaguart_tx_chars(pp);
> 
>   spin_unlock(&port->lock);

Yes - that stops ->tty becoming NULL while your handler is running

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/