linux-kernel - Re: [RESEND PATCH 2/2] serial: Add driver for the Altera UART

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 26 Feb 2010 22:50:22 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Tobias Klauser <tklauser@...tanz.ch>
Cc:	linux-serial@...r.kernel.org, nios2-dev@...c.et.ntust.edu.tw,
	linux-kernel@...r.kernel.org
Subject: Re: [RESEND PATCH 2/2] serial: Add driver for the Altera UART

A couple smatch complaints.

drivers/serial/altera_jtaguart.c
   380          if (co->index >= 0 && co->index <= ALTERA_JTAGUART_MAXPORTS)
   381                  co->index = 0;
   382          port = &altera_jtaguart_ports[co->index].port;

This test seems backward.  co->index == -1 would be a buffer underflow.

drivers/serial/altera_uart.c
   455          if ((co->index >= 0)
   456              && (co->index <= CONFIG_SERIAL_ALTERA_UART_MAXPORTS))
   457                  co->index = 0;
   458          port = &altera_uart_ports[co->index].port;

Same here.

regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/