linux-kernel - Re: [PATCH -mm 1/2] umh && creds: convert call_usermodehelper_keys() to use subprocess

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20100226182325.GA31674@redhat.com>
Date:	Fri, 26 Feb 2010 19:23:25 +0100
From:	Oleg Nesterov <oleg@...hat.com>
To:	David Howells <dhowells@...hat.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Andi Kleen <andi@...stfloor.org>,
	Neil Horman <nhorman@...driver.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm 1/2] umh && creds: convert
	call_usermodehelper_keys() to use subprocess_info->init()

On 02/26, David Howells wrote:
>
> Oleg Nesterov <oleg@...hat.com> wrote:
>
> > +	/*
> > +	 * This is called in context of freshly forked kthread before
> > +	 * kernel_execve(), we can just change our ->session_keyring.
> > +	 */
>
> Ummmm....  What gives you that idea?
>
> You may be sharing init_cred...

How? Without CLONE_THREAD copy_creds() always creates the new
struct cred for the child?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/