[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-ID: <4B8BAE79.9000609@s5r6.in-berlin.de>
Date: Mon, 01 Mar 2010 13:09:29 +0100
From: Stefan Richter <stefanr@...6.in-berlin.de>
To: linux-kernel@...r.kernel.org, Eric Dumazet <eric.dumazet@...il.com>
CC: "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org
Subject: sparse checking prevented by "net: fix kmemcheck annotations"
Hi all,
the post 2.6.32-rc5, pre 2.6.32-rc6 commit 14d18a81 causes a serious
regression for sparse checks: make C=1 CF="-D__CHECK_ENDIAN__" now
causes sparse to log
include/linux/skbuff.h:357:41: error: invalid bitfield specifier for
type restricted __be16.
I reported this already shortly after this hit the mainline. But back
then I didn't notice that this sparse error causes sparse to remain
silent on all subsequent warnings in a file!
We need to either change sparse to accept this bogus bit field that
occurs in skbuff.h (__be16 protocol:16;), silently or with a warning, or
revert this kmemcheck annotation.
("We" == preferably Eric :-)
skbuff.h is included by lots of drivers, even ones that are not even
networking drivers, notably DVB drivers. None of these drivers can be
checked with sparse's __CHECK_ENDIAN__ at the moment.
--
Stefan Richter
-=====-==-=- --== ----=
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists