linux-kernel - [tip:x86/atomic] lib: Fix atomic64_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tip-97577896f6b9c056fa0a5e9f6a608110cb3dcd33@git.kernel.org>
Date:	Mon, 1 Mar 2010 19:58:37 GMT
From:	tip-bot for Luca Barbieri <luca@...a-barbieri.com>
To:	linux-tip-commits@...r.kernel.org
Cc:	linux-kernel@...r.kernel.org, paulus@...ba.org, hpa@...or.com,
	mingo@...hat.com, luca@...a-barbieri.com, tglx@...utronix.de
Subject: [tip:x86/atomic] lib: Fix atomic64_add_unless return value convention

Commit-ID:  97577896f6b9c056fa0a5e9f6a608110cb3dcd33
Gitweb:     http://git.kernel.org/tip/97577896f6b9c056fa0a5e9f6a608110cb3dcd33
Author:     Luca Barbieri <luca@...a-barbieri.com>
AuthorDate: Mon, 1 Mar 2010 19:55:47 +0100
Committer:  H. Peter Anvin <hpa@...or.com>
CommitDate: Mon, 1 Mar 2010 11:38:46 -0800

lib: Fix atomic64_add_unless return value convention

atomic64_add_unless must return 1 if it perfomed the add and 0 otherwise.
The generic implementation did the opposite thing.

Reported-by: H. Peter Anvin <hpa@...or.com>
Confirmed-by: Paul Mackerras <paulus@...ba.org>
Signed-off-by: Luca Barbieri <luca@...a-barbieri.com>
LKML-Reference: <1267469749-11878-4-git-send-email-luca@...a-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@...or.com>
---
 lib/atomic64.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/atomic64.c b/lib/atomic64.c
index 8bee16e..a21c12b 100644
--- a/lib/atomic64.c
+++ b/lib/atomic64.c
@@ -162,12 +162,12 @@ int atomic64_add_unless(atomic64_t *v, long long a, long long u)
 {
 	unsigned long flags;
 	spinlock_t *lock = lock_addr(v);
-	int ret = 1;
+	int ret = 0;
 
 	spin_lock_irqsave(lock, flags);
 	if (v->counter != u) {
 		v->counter += a;
-		ret = 0;
+		ret = 1;
 	}
 	spin_unlock_irqrestore(lock, flags);
 	return ret;
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/