[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <tip-25a304f277ad70166eeae25a4958d2049005c33a@git.kernel.org>
Date: Mon, 1 Mar 2010 19:58:53 GMT
From: tip-bot for Luca Barbieri <luca@...a-barbieri.com>
To: linux-tip-commits@...r.kernel.org
Cc: linux-kernel@...r.kernel.org, hpa@...or.com, mingo@...hat.com,
luca@...a-barbieri.com, tglx@...utronix.de
Subject: [tip:x86/atomic] lib: Fix atomic64_inc_not_zero test
Commit-ID: 25a304f277ad70166eeae25a4958d2049005c33a
Gitweb: http://git.kernel.org/tip/25a304f277ad70166eeae25a4958d2049005c33a
Author: Luca Barbieri <luca@...a-barbieri.com>
AuthorDate: Mon, 1 Mar 2010 19:55:48 +0100
Committer: H. Peter Anvin <hpa@...or.com>
CommitDate: Mon, 1 Mar 2010 11:39:02 -0800
lib: Fix atomic64_inc_not_zero test
atomic64_inc_not_zero must return 1 if it perfomed the add and 0 otherwise.
The test assumed the opposite convention.
Signed-off-by: Luca Barbieri <luca@...a-barbieri.com>
LKML-Reference: <1267469749-11878-5-git-send-email-luca@...a-barbieri.com>
Signed-off-by: H. Peter Anvin <hpa@...or.com>
---
lib/atomic64_test.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/lib/atomic64_test.c b/lib/atomic64_test.c
index ee8e6de..f7bb706 100644
--- a/lib/atomic64_test.c
+++ b/lib/atomic64_test.c
@@ -130,16 +130,16 @@ static __init int test_atomic64(void)
#endif
INIT(onestwos);
- BUG_ON(atomic64_inc_not_zero(&v));
+ BUG_ON(!atomic64_inc_not_zero(&v));
r += one;
BUG_ON(v.counter != r);
INIT(0);
- BUG_ON(!atomic64_inc_not_zero(&v));
+ BUG_ON(atomic64_inc_not_zero(&v));
BUG_ON(v.counter != r);
INIT(-one);
- BUG_ON(atomic64_inc_not_zero(&v));
+ BUG_ON(!atomic64_inc_not_zero(&v));
r += one;
BUG_ON(v.counter != r);
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists